This repository was archived by the owner on Aug 2, 2021. It is now read-only.
Handle compress edge cases in pyramid chunker#713
Merged
Conversation
zelig
approved these changes
Jun 13, 2018
| return | ||
| } | ||
|
|
||
| // cleanChunkLevels removes gaps (nil levles) between chunk levels |
nonsense
approved these changes
Jun 14, 2018
Member
Author
|
Thank you for reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change solves the issue discovered by uploading a file 816778334 bytes long, and preserves the functionality of the previous cases. If compress is done multiple times, it should be by setting the chunk level to nil, and at the end to remove nil chunk levels with new function cleanChunkLevels.